Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify tooltip lint message #2999

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Clarify tooltip lint message #2999

merged 1 commit into from
Aug 7, 2024

Conversation

JoyceZhu
Copy link
Contributor

@JoyceZhu JoyceZhu commented Aug 7, 2024 •
edited
Loading

Briefly explains what the options for doing
something actionable are to users

What are you trying to accomplish?

Screenshots

Integration

List the issues that this change affects.

Closes #2998

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@JoyceZhu
Clarify tooltip lint message
0dae439 
Briefly explains what the options for doing
something actionable are to users
@JoyceZhu JoyceZhu requested a review from khiga8 August 7, 2024 16:07
@JoyceZhu JoyceZhu requested a review from a team as a code owner August 7, 2024 16:07
@JoyceZhu JoyceZhu requested a review from langermank August 7, 2024 16:07
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: 0dae439

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

khiga8
khiga8 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@JoyceZhu JoyceZhu added the skip changeset Pull requests that don't change the library output label Aug 7, 2024
@JoyceZhu JoyceZhu merged commit 4a358c7 into main Aug 7, 2024
43 of 44 checks passed
@JoyceZhu JoyceZhu deleted the joycezhu/clarify_tooltip_lint_mesage branch August 7, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khiga8 khiga8 khiga8 approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify .tooltipped migration linter message
2 participants
@JoyceZhu @khiga8